Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ia): regression, updated ras endpoint #3566

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix(ia): regression, updated ras endpoint #3566

merged 1 commit into from
Nov 22, 2024

Conversation

jaredrethman
Copy link
Collaborator

@jaredrethman jaredrethman commented Nov 22, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Fixes endpoint for Reader Activation "Site Status" caused by regression introduced in #3500

How to test the changes in this Pull Request:

  1. Checkout this branch - git checkout origin/fix/ia-dashboard-ras-endpoint
  2. Navigate to /wp-admin/admin.php?page=newspack-dashboard#/ and confirm Reader Activation "Site Status" works correctly.
Before After
Screenshot 2024-11-20 at 13 15 18                                                                                          Screenshot 2024-11-22 at 08 16 17 Screenshot 2024-11-22 at 08 20 27

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@jaredrethman jaredrethman marked this pull request as ready for review November 22, 2024 14:25
@jaredrethman jaredrethman requested a review from a team as a code owner November 22, 2024 14:25
@jaredrethman jaredrethman added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 22, 2024
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 22, 2024
@jaredrethman jaredrethman merged commit 92384d8 into epic/ia Nov 22, 2024
9 checks passed
@jaredrethman jaredrethman deleted the fix/ia-dashboard-ras-endpoint branch November 22, 2024 14:35
@jaredrethman jaredrethman restored the fix/ia-dashboard-ras-endpoint branch November 22, 2024 17:16
This was referenced Nov 22, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelpeixe miguelpeixe miguelpeixe approved these changes

Assignees
No one assigned
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaredrethman @miguelpeixe